Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Remove doctrine migrate and cr setup commands from behat scripts #5284

Open
wants to merge 1 commit into
base: 9.0
Choose a base branch
from

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Oct 13, 2024

Alternative fix to #5005 or the commits in #4988

When the ci is run without the doctrine schema setup the behat helper @flowEntities will create the schema.
This unfortunately messes with the transaction level as debugged:

array(2) {
  ["getTransactionNestingLevel"]=>
  int(119)
  ["isTransactionActive"]=>
  bool(true)
}

The working state - when the schema exists already - looks like this

array(2) {
  ["getTransactionNestingLevel"]=>
  int(0)
  ["isTransactionActive"]=>
  bool(false)
}

The CI complains with errors like

A transaction is active already, can't commit events!

or

Failed to acquire checkpoint lock for subscriber "Neos\ContentRepository\Core\Projection\ContentStream\ContentStreamProjection" because a transaction is active

But with neos/behat#40 we fix the problem and reset the transactions after the migration, so that we can remove the ci hack ./../flow doctrine:migrate.

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign force-pushed the bugfix/a-transaction-is-already-remove-doctrine-migrate-hack branch from f32c825 to 79ebc80 Compare October 17, 2024 09:07
@mhsdesign mhsdesign marked this pull request as ready for review October 17, 2024 09:07
@mhsdesign mhsdesign changed the title BUGFIX: Remove doctrine migrate and cr setup commands from behat scripts TASK: Remove doctrine migrate and cr setup commands from behat scripts Oct 29, 2024
@github-actions github-actions bot added the Task label Oct 29, 2024
@mhsdesign
Copy link
Member Author

Actually, due to this line in CI #5258 (comment) we now do doctrine:migrate at another place already so we wouldnt even need the adjustments of neos/behat#40 that are merged now.

But its good to have that hack cleaned up here from the composer scripts, so id say we can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants