feat: improve default haxe_language_server init_options #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glepnir
reviewed
Aug 25, 2024
| @@ -1,18 +1,36 @@ | |||
| local util = require 'lspconfig.util' | |||
|
|
|||
| local function find_hxml(path) | |||
| return vim.fs.find(function(name) | |||
There was a problem hiding this comment.
vim.fs.root seems to return the parent directory, but I'd like to find a file. e.g. /path/to/project/build.hxml
| init_options = {}, | ||
| on_new_config = function(new_config, new_root_dir) | ||
| if new_config.init_options.displayArguments then | ||
| print 'displayArguments already set. Skipping' |
There was a problem hiding this comment.
This one I left in by mistake while debugging. I've replaced the other one with vim.notify.
tobil4sk
force-pushed
the
improve-haxe-config
branch
from
dc97f6c to
964497f
Compare
Previously, it would detect the root dir by matching with "*.hxml", however, it would use "build.hxml" as the default `displayArguments` even though it may not exist. This could cause the error: ``` haxe_language_server: -32603: Error: Could not process argument build.hxml (file not found) Invalid character: ``` Now it will use the first ".hxml" file that is found in the project. It will only do this if no `displayArguments` value has been set in the `setup()` call, so it will still respect user set values. If no hxml file is found, then it uses empty `displayArguments`, which is still better than a broken configuration.
tobil4sk
force-pushed
the
improve-haxe-config
branch
from
964497f to
f342b7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
.gitas a root directory pattern.Previously, it would detect the root dir by matching with "*.hxml", however, it
would use "build.hxml" as the default
displayArgumentseven though it may notexist. This could cause the error:
Now it will use the first ".hxml" file that is found in the project. It will
only do this if no
displayArgumentsvalue has been set in thesetup()call,so it will still respect user set values.
If no hxml file is found, then it uses empty
displayArguments, which is stillbetter than a broken configuration.