fix(ccls): typo on request method #3536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: method prefix is textDocument Solution: make d to upper
MaskRay
reviewed
Jan 2, 2025
| @@ -7,7 +7,7 @@ local function switch_source_header(bufnr) | |||
| vim.notify('method textdocument/switchsourceheader is not supported by any servers active on the current buffer') | |||
| end | |||
| local params = vim.lsp.util.make_text_document_params(bufnr) | |||
| client.request('textdocument/switchsourceheader', params, function(err, result) | |||
| client.request('textDocument/switchsourceheader', params, function(err, result) | |||
There was a problem hiding this comment.
The correct spelling is textDocument/switchSourceHeader and the message above needs to be fixed as well.
There was a problem hiding this comment.
will fix on refactor PR there lots of duplicate codes on clangd.
There was a problem hiding this comment.
switchsourceheader is correct? in clangd is switchSourceHeader
There was a problem hiding this comment.
textDocument/switchSourceHeader, the same as clangd :)
I had used the function copied from clangd for a while https://github.com/MaskRay/Config/blob/1f431c999079e900bbe7958a00578cba4c4b3b67/home/.config/nvim/lua/my/util.lua#L41 until I attempted to upstream it...
MaskRay
reviewed
Jan 2, 2025
| @@ -7,7 +7,7 @@ local function switch_source_header(bufnr) | |||
| vim.notify('method textdocument/switchsourceheader is not supported by any servers active on the current buffer') | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: method prefix is textDocument
Solution: make d to upper