Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(msbuild): more root patterns #3542

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Conversation

sharpchen
Copy link
Contributor

No description provided.

@sharpchen sharpchen requested a review from glepnir as a code owner January 5, 2025 05:05
@glepnir
Copy link
Member

glepnir commented Jan 5, 2025

does there any information about these filetypes are supported by this server?

Copy link
Member

@justinmk justinmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't *.sln be prioritized (i.e. make it first in the list)?

@sharpchen sharpchen force-pushed the msbuild-root branch 2 times, most recently from 77aefd1 to b0c1845 Compare January 5, 2025 12:57
@sharpchen
Copy link
Contributor Author

does there any information about these filetypes are supported by this server?

https://github.com/tintoy/msbuild-project-tools-vscode?tab=readme-ov-file#file-extensions

And I might misunderstand the root_parttern, does this implies the server only auto start when the current working directory matches any of the patterns, if not then sln and slnx might be redundant.

shouldn't *.sln be prioritized (i.e. make it first in the list)?

right, updated.

@justinmk justinmk merged commit 5e009bd into neovim:master Jan 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants