Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slangd): use .slang instead of .shaderslang for slang #3544

Closed
wants to merge 1 commit into from

Conversation

mTvare6
Copy link

@mTvare6 mTvare6 commented Jan 5, 2025

The extension used by slang is .slang.
Examples and docs for reference.

@mTvare6 mTvare6 requested a review from glepnir as a code owner January 5, 2025 15:45
@lithammer
Copy link
Collaborator

This isn't a file extension though. It's a filetype1.

Footnotes

  1. https://vimhelp.org/filetype.txt.html

@mTvare6
Copy link
Author

mTvare6 commented Jan 5, 2025

My bad, but neovim itself doesn't have a shaderslang filetype yet either way.

@mTvare6 mTvare6 closed this Jan 5, 2025
@mTvare6 mTvare6 deleted the fix-slang-extension branch January 5, 2025 17:21
@lithammer
Copy link
Collaborator

Seems like the filetype was added to nvim-treesitter. So you would need that and enable "slang" for his to make sense.

The filetype shaderslang is a invention of myself, but I plan to also use it for a tree-sitter parser nvim-treesitter/nvim-treesitter#5659 and a TBD PR to vim for filetype detection. shaderslang is used because Vim/Neovim already has support for a filetype called slang which I assume is for https://en.wikipedia.org/wiki/S-Lang with extension *.sl while shaderslang uses *.slang.

@mTvare6
Copy link
Author

mTvare6 commented Jan 10, 2025

Vim now supports shaderslang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants