Stop PackageRevision updates from changing creationTimestamp #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tamp
- wired CreationTimestamp in from underlying PackageRev CR when getting
a PackageRevision together from Git
- as mentioned as an option in old comment
kptdev/kpt#3992 (comment)
- and same in OCI implementation for consistency's sake
- previous implementation got CreationTimestamp from 'updated' attribute
which is got from the creation timestamp of the latest commit to the
branch in Git, and so kept changing
- underlying PackageRev CR is a Kubernetes object and has a static
creationTimestamp
- wired PackageRev details/ObjectMeta data into PackageRevision returned
from update-package-resources flow
- was previously just empty values with a zero timestamp
- which broke a test once the creationTimestamp fix was applied
nephio-project/nephio#630
Catalin-Stratulat-Ericsson
approved these changes
Feb 13, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Catalin-Stratulat-Ericsson, JamesMcDermott The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #630