Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing path for images that do not have git installed #213

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

radoslawc
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Some test images don't have git installed thus rev-parse fails to show top level of directory.
Which issue(s) this PR fixes:

Fixes #
Failing tests in #212
Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@electrocucaracha
Copy link
Member

/lgtm

@electrocucaracha
Copy link
Member

/approve

Copy link
Contributor

nephio-prow bot commented Nov 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Nov 4, 2023
@nephio-prow nephio-prow bot merged commit d1dc304 into nephio-project:main Nov 4, 2023
2 of 3 checks passed
dkosteck pushed a commit to vjayaramrh/test-infra that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants