Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments WRT Qt ≥ 5.9 #2

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Update comments WRT Qt ≥ 5.9 #2

merged 2 commits into from
Aug 1, 2022

Conversation

Olf0
Copy link

@Olf0 Olf0 commented Jul 30, 2022

No description provided.

@nephros
Copy link
Owner

nephros commented Aug 1, 2022

Actually I think I merged this too quickly - it does not really fit the purpose of the feature branch (which is to deal with storeman-developers#301).

I have cherry-picked these and pushed to a new branch https://github.com/nephros/harbour-storeman/tree/todo-qt and will rebase, drop and forcepush the rename-service branch.

If we decide to actually release the sailjail stuff, these can be merged in as well.

@Olf0
Copy link
Author

Olf0 commented Aug 1, 2022

Actually I think I merged this too quickly - it does not really fit the purpose of the feature branch (which is to deal with storeman-developers#301).

True.

I have cherry-picked these and pushed to a new branch https://github.com/nephros/harbour-storeman/tree/todo-qt and will rebase, drop and forcepush the rename-service branch.

Fine.

If we decide to actually release the sailjail stuff, these can be merged in as well.

No, I would like to merge them now, as they resolve two of the many points listed at storeman-developers#356

But, before I also merge this too quickly: Do you see any reason not to merge storeman-developers#357 now?

@nephros
Copy link
Owner

nephros commented Aug 3, 2022

No, I would like to merge them now, as they resolve two of the many points listed at storeman-developers#356

But, before I also merge this too quickly: Do you see any reason not to merge storeman-developers#357 now?

Not really, no.

@Olf0
Copy link
Author

Olf0 commented Aug 3, 2022

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants