rubocop

app/models/leave.rb

@@ -69,8 +69,10 @@ def notify_slack_about_sick_leave
   end
 
   def notify_hr_on_slack_about_new_request
-    Slack.instance.notify(channel: Config.slack_hr_channel_id,
-      text: Leave::Notification.new(leave: self).hr_leave_request_message) if Config.slack_hr_channel_id.present?
+    if Config.slack_hr_channel_id.present?
+      Slack.instance.notify(channel: Config.slack_hr_channel_id,
+        text: Leave::Notification.new(leave: self).hr_leave_request_message)
+    end
   end
 
   def notify_user_on_slack_about_status_change

app/views/components/_current_user.props.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 field :current_user, global: :current_user do
   field :id
   field :display_name

app/views/inventories/edit.props.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 field :inventory, value: -> { @inventory } do
   field :id
   field :name

app/views/inventories/new.props.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 field :user, value: -> { @inventory.user } do
   field :id
 end

app/views/leaves/index.props.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 render "components/current_user"
 
 field :feed_url, value: -> { helpers.feed_leaves_url(auth: current_user.id, format: :ics, protocol: :webcal) }

app/views/leaves/new.props.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 render "components/current_user"
 
 field :permit_user_select, Boolean, value: -> { helpers.policy(Leave).show_all_users? }

app/views/pages/home.props.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 render "components/current_user"
 
 field :upcoming_leaves, array: true, value: -> { @upcoming_leaves } do

app/views/payslips/index.props.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 render "components/current_user"
 
 field :payslips, array: true, value: -> { @payslips } do

app/views/payslips/new.props.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 field :users, array: true, value: -> { User.currently_employed.alphabetically } do
   field :id
   field :display_name

app/views/sprint_feedbacks/show.props.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 render "components/current_user"
 
 field :feedback, value: -> { @feedback } do

app/views/sprints/index.props.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 render "components/current_user"
 
 field :sprints, array: true, value: -> { @sprints } do

app/views/users/index.props.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 render "components/current_user"
 
 field :filter, value: -> { @filter }

app/views/users/show.props.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 render "components/current_user"
 
 field :user, value: -> { @user } do

lib/reaction.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 module Reaction
 end

lib/reaction/controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Reaction
   module Controller
     extend ActiveSupport::Concern
@@ -16,7 +18,7 @@ def default_render
           end
           format.json do
             return head :no_content if reaction_request?
-            render json: Response.new(component: "#{controller_path}/#{action_name}", context: self.view_context).to_s
+            render json: Response.new(component: "#{controller_path}/#{action_name}", context: view_context).to_s
           end
         end
       end

lib/reaction/props/field.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Reaction
   module Props
     class Field

lib/reaction/props/schema.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Reaction
   module Props
     class Schema
@@ -6,7 +8,7 @@ class Schema
 
       def initialize(string)
         @root = Field.new(:root, Object, null: false, parent: self)
-        @root.instance_exec { binding.eval(string) }
+        @root.instance_exec { binding.eval(string) } # rubocop:disable Security/Eval the imported string is under the developers control and therefore should not include any injections
       end
 
       def serialize(object)

lib/reaction/props/value_proxy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Reaction
   module Props
     class ValueProxy < SimpleDelegator

lib/reaction/response.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Reaction
   class Response
     attr_reader :schema, :component

lib/reaction/tsx_handler.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Reaction
   class TsxHandler
     class << self

spec/fixtures/files/example_schema.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 field :current_user do
   field :first_name
   field :email, null: false

spec/models/prop_schema_spec.rb

@@ -2,10 +2,10 @@
 
 require "rails_helper"
 
-RSpec.describe PropSchema do
+RSpec.describe Reaction::Props::Schema do
   describe "#initialize" do
     it "parses a tree of properties using a DSL" do
-      schema = PropSchema.new(Rails.root.join("spec/fixtures/files/example_schema.rb"))
+      schema = Reaction::Props::Schema.new(Rails.root.join("spec/fixtures/files/example_schema.rb"))
       root = schema.root
       current_user = root.fields[:current_user]
       expect(root.name).to eq :root
@@ -20,7 +20,7 @@
 
     describe "#serialize" do
       it "serializes a tree of properties" do
-        schema = PropSchema.new(Rails.root.join("spec/fixtures/files/example_schema.rb"))
+        schema = Reaction::Props::Schema.new(Rails.root.join("spec/fixtures/files/example_schema.rb"))
         serialized = schema.serialize(OpenStruct.new({
           current_user: {
             first_name: "John",