Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when selected leave days are in the past #85

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

danieldiekmeier
Copy link
Contributor

Resolves #76.

This is a suggestion on how we could resolve #76: If some of the selected dates are in the past, you get a little yellow text that warns you. It doesn't block you from submitting the form, but it should serve as enough of a warning to avoid mixing up the dates.

image

@danieldiekmeier danieldiekmeier added the frontend Requires a frontend developer. label Feb 2, 2024
@danieldiekmeier danieldiekmeier force-pushed the feature/warn-when-leave-is-in-the-past branch from f029f19 to 31672ce Compare February 2, 2024 15:05
Copy link
Member

@JensRavens JensRavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a test for this?

@danieldiekmeier
Copy link
Contributor Author

@JensRavens Sure, I added one!

@JensRavens JensRavens merged commit 4f58712 into main Feb 6, 2024
1 check passed
@JensRavens JensRavens deleted the feature/warn-when-leave-is-in-the-past branch February 6, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Requires a frontend developer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable requesting of leaves after a certain time
3 participants