Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily Nerd posts to wrong channel #94

Merged
merged 7 commits into from
Apr 24, 2024

Conversation

oma-s
Copy link
Contributor

@oma-s oma-s commented Apr 23, 2024

fixes #92

‼️ NOTE:

For this to work in production we need to set a config var on heroku:

slack_daily_nerd_channel = "the-daily-nerd"

@oma-s oma-s self-assigned this Apr 23, 2024
@oma-s oma-s marked this pull request as ready for review April 23, 2024 12:47
@jmarsh24
Copy link
Member

Is it possible to put the formatting in a separate PR? Otherwise it's difficult to read what actually changed.

@oma-s
Copy link
Contributor Author

oma-s commented Apr 23, 2024

Is it possible to put the formatting in a separate PR? Otherwise it's difficult to read what actually changed.

@jmarsh24 The CI would fail. We could open a PR with the linting and gem updates and quickly merge it.
I'll do that in a few

@oma-s
Copy link
Contributor Author

oma-s commented Apr 23, 2024

Is it possible to put the formatting in a separate PR? Otherwise it's difficult to read what actually changed.

@jmarsh24 now it should be readable ;)

@oma-s oma-s merged commit b37b21c into main Apr 24, 2024
1 check passed
@oma-s oma-s deleted the feature/92_daily_nerd_posts_to_wrong_channel branch April 24, 2024 21:44
JensRavens added a commit that referenced this pull request Apr 25, 2024
JensRavens added a commit that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily Nerd posts to wrong channel
3 participants