-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Fisheye-GS. #398
Merged
liruilong940607
merged 41 commits into
nerfstudio-project:main
from
jefequien:jeff/fisheye
Sep 26, 2024
Merged
Changes from 30 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
27fa353
baseline
jefequien 96089a1
fisheye forward works
jefequien 30b4579
torch implementation of fisheye projection
jefequien c4651c0
test basic
jefequien 712ae95
close 0.3%
jefequien 01daadb
19 mismatched
jefequien 2de03b9
pass tests
jefequien 9c61743
comment out
jefequien 6347c49
crashing
jefequien 6e56adf
remove dead code
jefequien cb08427
reduce diff
jefequien 22060d5
video
jefequien 139f7fe
distortion not handled correctly
jefequien fde16f8
test remap
jefequien 37f40a5
remove hardcoded roi
jefequien 98a7819
cleanup tests
jefequien 67baaae
fix bug
jefequien e41679d
bug
jefequien 1ed34f0
edit imsize_dict
jefequien 4434f09
format c++
jefequien 3948fc9
T
jefequien ce98242
use mask
jefequien 66128ca
remove test_remap
jefequien 419c9e1
mask roi
jefequien 4211157
scripts
jefequien 148c218
reduce diff
jefequien 6adbf6d
minor
jefequien 4663665
Merge branch 'main' into jeff/fisheye
jefequien c2e7ada
weird ortho bug
jefequien 412ea62
Merge branch 'main' into jeff/fisheye
jefequien a31e65a
vectorize
jefequien 41aa398
ellipse
jefequien 7f2972a
unify python side camera_model
jefequien 593769c
fisheye packed mode
jefequien b133704
Merge branch 'main' into jeff/fisheye
jefequien 07d2087
cuda enum
jefequien e737073
use c++ enum
jefequien fa23297
download dataset
jefequien 2065224
refactor dataset download to download zipnerf
jefequien 6fe028d
use lists
jefequien e6c19d6
use bilateral grid as default for zipnerf
jefequien File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
SCENE_DIR="data/zipnerf" | ||
SCENE_LIST="berlin london nyc alameda" | ||
DATA_FACTOR=2 | ||
|
||
RESULT_DIR="results/benchmark_mcmc_2M_zipnerf" | ||
CAP_MAX=2000000 | ||
|
||
# RESULT_DIR="results/benchmark_mcmc_4M_zipnerf" | ||
# CAP_MAX=4000000 | ||
|
||
for SCENE in $SCENE_LIST; | ||
do | ||
echo "Running $SCENE" | ||
|
||
# train and eval | ||
CUDA_VISIBLE_DEVICES=0 python simple_trainer.py mcmc --disable_viewer --data_factor $DATA_FACTOR \ | ||
--strategy.cap-max $CAP_MAX \ | ||
--opacity_reg 0.001 \ | ||
--camera_model fisheye \ | ||
--data_dir $SCENE_DIR/$SCENE/ \ | ||
--result_dir $RESULT_DIR/$SCENE/ | ||
done |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
SCENE_DIR="data/zipnerf_undistort" | ||
SCENE_LIST="berlin london nyc alameda" | ||
DATA_FACTOR=2 | ||
|
||
RESULT_DIR="results/benchmark_mcmc_2M_zipnerf_undistort" | ||
CAP_MAX=2000000 | ||
|
||
# RESULT_DIR="results/benchmark_mcmc_4M_zipnerf_undistort" | ||
# CAP_MAX=4000000 | ||
|
||
for SCENE in $SCENE_LIST; | ||
do | ||
echo "Running $SCENE" | ||
|
||
# train and eval | ||
CUDA_VISIBLE_DEVICES=0 python simple_trainer.py mcmc --disable_viewer --data_factor $DATA_FACTOR \ | ||
--strategy.cap-max $CAP_MAX \ | ||
--opacity_reg 0.001 \ | ||
--camera_model pinhole \ | ||
--data_dir $SCENE_DIR/$SCENE/ \ | ||
--result_dir $RESULT_DIR/$SCENE/ | ||
done |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
batchify this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done