Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix array mutation bugs #319

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Fix array mutation bugs #319

merged 2 commits into from
Nov 8, 2024

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented Nov 7, 2024

We previously:

  • Used arrays passed as input directly in internal state
  • Later checked the internal state for lazy updates

This causes problems when arrays passed as input are mutated externally.

Fixes #318

@brentyi brentyi mentioned this pull request Nov 7, 2024
Closed
@brentyi brentyi merged commit aa2cdc9 into main Nov 8, 2024
15 checks passed
@brentyi brentyi deleted the brent/copy_arrays branch November 8, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@brentyi