Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix z-fighting artifacts in new camera frustums #333

Merged
merged 1 commit into from
Nov 12, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/viser/client/src/ThreeAssets.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -774,7 +774,8 @@ export const CameraFrustum = React.forwardRef<
/>
{imageTexture && (
<mesh
position={[0.0, 0.0, z]}
// 0.999999 is to avoid z-fighting with the frustum lines.
position={[0.0, 0.0, z * 0.999999]}
rotation={new THREE.Euler(Math.PI, 0.0, 0.0)}
>
<planeGeometry
Expand Down
Loading