Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebecca/shadows #375

Merged
merged 11 commits into from
Feb 14, 2025
Merged

Rebecca/shadows #375

merged 11 commits into from
Feb 14, 2025

Conversation

beckyfeng08
Copy link
Collaborator

shadows for meshes and trimeshes as is

Copy link
Collaborator

@brentyi brentyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited for shadow support!!!

src/viser/_messages.py Outdated Show resolved Hide resolved
src/viser/_messages.py Outdated Show resolved Hide resolved
src/viser/_scene_api.py Outdated Show resolved Hide resolved
src/viser/client/src/App.tsx Show resolved Hide resolved
src/viser/client/src/ThreeAssets.tsx Outdated Show resolved Hide resolved
src/viser/client/src/ThreeAssets.tsx Outdated Show resolved Hide resolved
@brentyi
Copy link
Collaborator

brentyi commented Feb 13, 2025

Some additional suggestions:

@brentyi brentyi merged commit c641ec3 into main Feb 14, 2025
15 checks passed
@brentyi brentyi deleted the rebecca/shadows branch February 14, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants