Fix mergeNpcDataWithNpcIconData errors in console due to incorrect ic…

…on format on changed npcs
nerthus-margonem · Nov 23, 2024 · 3cd79ab · 3cd79ab
1 parent 837b171
commit 3cd79ab
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/app/npc/update-npc-image.js b/src/app/npc/update-npc-image.js
@@ -48,9 +48,6 @@ export async function updateNpcWithCustomGifImage(npc, gifIconUrl)
 
 export function updateNpcWithGameImage(npc, imgUrl)
 {
-    Object.defineProperty(npc.d, 'icon', {
-        get() {return imgUrl}, set() {}
-    })
     const beforeOnload = npc.beforeOnload
     npc.beforeOnload = function (data, img, npc)
     {
@@ -59,5 +56,11 @@ export function updateNpcWithGameImage(npc, imgUrl)
             beforeOnload.call(npc, ...arguments)
         }
     }
-    setTimeout(() => Engine.npcs.updateData([npc.d]), 1)
+    setTimeout(() =>
+    {
+        npc.d.icon = {
+            special: imgUrl
+        }
+        Engine.npcs.updateData([npc.d])
+    }, 1)
 }