Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger message count to MOTD #98

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mnishiguchi
Copy link
Member

@mnishiguchi mnishiguchi commented Oct 31, 2022

resolves #80

CleanShot 2022-10-30 at 20 12 40@2x

Notes

TODO

  • update RingLogger to return statistics on types of messages
  • adjust the count

@fhunleth
Copy link
Member

I had a thought on this feature based on some recent usage: I'd like to know if I have any messages that are warnings or errors as well. For example, I'd probably ignore 196 info/debug messages most of the time, but if I saw that there was an error, I'd definitely check the log.

This would require an update to RingLogger to provide counts based on types. Since the function that was added to return the unread message count hasn't been officially released, I think that we can update it to return statistics on types of messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report how many log messages are pending
2 participants