Support mount #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuJiandong
requested changes
Oct 12, 2023
| @@ -460,6 +461,18 @@ static JSValue syscall_current_memory(JSContext *ctx, JSValueConst this_value, i | |||
| return JS_NewUint32(ctx, (uint32_t)size); | |||
| } | |||
|
|
|||
| static JSValue mount(JSContext *ctx, JSValueConst this_value, int argc, JSValueConst *argv) { | |||
| JSValue buf = syscall_load_cell_data(ctx, this_value, argc, argv); | |||
quickjs/ckb_module.c
Outdated
| @@ -501,6 +514,8 @@ int js_init_module_ckb(JSContext *ctx) { | |||
| JS_NewCFunction(ctx, syscall_get_memory_limit, "get_memory_limit", 0)); | |||
| JS_SetPropertyStr(ctx, ckb, "current_memory", | |||
| JS_NewCFunction(ctx, syscall_current_memory, "current_memory", 0)); | |||
| JS_SetPropertyStr(ctx, ckb, "mount", | |||
| JS_NewCFunction(ctx, mount, "mount", 3)); | |||
There was a problem hiding this comment.
mount has only 2 arguments.
quickjs/qjs.c
Outdated
| @@ -304,18 +318,23 @@ int main(int argc, const char **argv) { | |||
| switch (type) { | |||
| case RunJsWithCode: | |||
| err = eval_buf(ctx, argv[1], strlen(argv[1]), "<cmdline>", 0); | |||
| js_std_loop(ctx); | |||
There was a problem hiding this comment.
When error occurs, no need to continue.
| @@ -0,0 +1,11 @@ | |||
| /* example of JS module */ | |||
|
|
|||
| ckb.mount(2, 3) | |||
There was a problem hiding this comment.
use ckb consts. e.g. ckb.SOURCE_INPUT.
|
Don't forget updating the document in docs/syscalls.md. |
XuJiandong
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.