Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact dao #70

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

refact dao #70

wants to merge 4 commits into from

Conversation

liuck8080
Copy link
Contributor

what does this PR do?

  1. Support simple transaction builder for DAO deposit, 2 withdraw phrase2.
  2. Add prepare_transaction step, so before build, can do some prepare.
  3. Change handler context to mut reference, so some middle states can store in the context.

@liuck8080 liuck8080 requested a review from quake May 11, 2023 11:19
@liuck8080 liuck8080 self-assigned this May 11, 2023
@liuck8080 liuck8080 marked this pull request as ready for review May 11, 2023 12:15
@liuck8080 liuck8080 force-pushed the feat/refact_dao_20230505 branch from 471d566 to dae479a Compare May 11, 2023 12:18
fix: 🐛 fix transaction builder witness empty problem
6fcf80a 
1. witness can have empty data; 2. transaction input only have necessary
data.
@liuck8080 liuck8080 changed the title Feat/refact dao 20230505 refact dao May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake Awaiting requested review from quake

Assignees

@quake quake

@liuck8080 liuck8080

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuck8080 @quake