Merge pull request #4795 from eval-exec/exec/get-peers-dedup

`NetRpcImpl::get_peers` return `Remoteaddress.addresses` dedup
nervosnetwork · Jan 24, 2025 · 05aa7b6 · 05aa7b6
2 parents b44d2d2 + 9508269
commit 05aa7b6
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/rpc/src/module/net.rs b/rpc/src/module/net.rs
@@ -11,6 +11,7 @@ use ckb_systemtime::unix_time_as_millis;
 use ckb_types::prelude::{Pack, Unpack};
 use jsonrpc_core::Result;
 use jsonrpc_utils::rpc;
+use std::collections::HashSet;
 use std::sync::Arc;
 
 const MAX_ADDRS: usize = 50;
@@ -586,8 +587,9 @@ impl NetRpc for NetRpcImpl {
             .connected_peers()
             .iter()
             .map(|(peer_index, peer)| {
-                let mut addresses = vec![&peer.connected_addr];
-                addresses.extend(peer.listened_addrs.iter());
+                let addresses: HashSet<_> = std::iter::once(peer.connected_addr.clone())
+                    .chain(peer.listened_addrs.iter().cloned())
+                    .collect();
 
                 let node_addresses = addresses
                     .iter()