Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix valid_dao_withdraw_transaction #4184

Closed
wants to merge 1 commit into from
Closed

Fix valid_dao_withdraw_transaction #4184

wants to merge 1 commit into from

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Oct 11, 2023 •
edited
Loading

What problem does this PR solve?

Fix the merge queue CI failure in #4183:
And CI failure in latest develop branch: https://github.com/nervosnetwork/ckb/commits/develop/

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec marked this pull request as ready for review October 11, 2023 03:14
@eval-exec eval-exec requested a review from a team as a code owner October 11, 2023 03:14
@eval-exec eval-exec force-pushed the exec/fix-valid_dao_withdraw_transaction-panic branch 2 times, most recently from a35205a to 733e9e9 Compare October 11, 2023 03:32
@eval-exec eval-exec marked this pull request as draft October 11, 2023 03:34
@eval-exec
Copy link
Collaborator Author

Change !(self.resolved_transaction.is_cellbase() || self.valid_dao_withdraw_transaction()) to !self.resolved_transaction.is_cellbase() && !self.valid_dao_withdraw_transaction() cannot help fix the CI failure.

@eval-exec eval-exec force-pushed the exec/fix-valid_dao_withdraw_transaction-panic branch from 733e9e9 to d153a9e Compare October 11, 2023 03:44
@eval-exec eval-exec marked this pull request as ready for review October 11, 2023 03:46
@eval-exec eval-exec closed this Oct 11, 2023
@eval-exec
Copy link
Collaborator Author

Replaced by #4186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eval-exec