Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CheckCellDeps transaction fee not enough #4234

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Nov 16, 2023

What problem does this PR solve?

This PR want to fix https://github.com/nervosnetwork/ckb/actions/runs/6847588555/job/18616144298 :

2023-11-16 04:18:03.847 +00:00 main INFO ckb_test  [CheckCellDeps] Start executing
2023-11-16 04:18:03.847 +00:00 *unnamed* INFO ckb_test::node  working_dir "/var/folders/_m/f2pp9dy135ng8gb3z154mgkh0000gn/T/ckb-it-CheckCellDeps-node0-Ie8GHW"
2023-11-16 04:18:05.384 +00:00 *unnamed* ERROR panic  thread 'unnamed' panicked at 'rpc call send_transaction: {"code":-1108,"message":"PoolRejectedMalformedTransaction: Malformed Overflow transaction","data":"Malformed(\"Overflow\", \"expect (outputs capacity) <= (inputs capacity)\")"}': src/rpc.rs:197   0: backtrace::capture::Backtrace::create
   1: backtrace::capture::Backtrace::new

Problem Summary:

What is changed and how it works?

In Dummy mode, epoch_length_target will affect the epoch length, the epoch length will affect block_reward and remainder_reward.
So in CheckCellDeps, we should specify spec.params.epoch_duration_target with Some(GENESIS_EPOCH_LENGTH * 8) to let epoch_length be GENESIS_EPOCH_LENGTH forever.

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from a team as a code owner November 16, 2023 13:12
@eval-exec eval-exec requested review from zhangsoledad and chenyukang and removed request for a team November 16, 2023 13:12
@quake quake merged commit cab5389 into nervosnetwork:develop Nov 17, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants