Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BlockNumberAndHash fromckb-sync to ckb-types #4494

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Move BlockNumberAndHash fromckb-sync to ckb-types #4494

merged 1 commit into from
Jun 26, 2024

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Jun 25, 2024 •
edited
Loading

What problem does this PR solve?

I think BlockNumberAndHash is more suitable to be placed in ckb-types. Moreover, I want to use BlockNumberAndHash in ckb-db and ckb-db-schema.

What's Changed:

Related changes

  • Move struct BlockNumberAndHash to ckb-types

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec requested a review from a team as a code owner June 25, 2024 12:00
@eval-exec eval-exec requested review from zhangsoledad and removed request for a team June 25, 2024 12:00
@quake quake added this pull request to the merge queue Jun 26, 2024
Merged via the queue into nervosnetwork:develop with commit 189e665 Jun 26, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @quake