Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrade openssl crate #4533

Merged
merged 2 commits into from
Jul 22, 2024
Merged

chore(deps): upgrade openssl crate #4533

merged 2 commits into from
Jul 22, 2024

Conversation

doitian
Copy link
Member

@doitian doitian commented Jul 22, 2024 •
edited
Loading

What problem does this PR solve?

Problem Summary:

error[vulnerability]: `MemBio::get_buf` has undefined behavior with empty buffers
    ┌─ /home/runner/work/ckb/ckb/Cargo.lock:313:1
    │
313 │ openssl 0.10.64 registry+https://github.com/rust-lang/crates.io-index
    │ --------------------------------------------------------------------- security vulnerability detected
    │
    = ID: RUSTSEC-2024-0357
    = Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0357
    = Previously, `MemBio::get_buf` called `slice::from_raw_parts` with a null-pointer, which violates the functions invariants, leading to undefined behavior. In debug builds this would produce an assertion failure. This is now fixed.
    = Announcement: https://github.com/sfackler/rust-openssl/pull/2266
    = Solution: Upgrade to >=0.10.66 (try `cargo update -p openssl`)

What is changed and how it works?

What's Changed:

cargo update -p openssl

Check List

Tests

  • Unit test
  • Integration test

Release note 

None: Exclude this PR from the release note.

@doitian
chore(deps): upgrade openssl crate
4957ce8 
```
error[vulnerability]: `MemBio::get_buf` has undefined behavior with empty buffers
    ┌─ /home/runner/work/ckb/ckb/Cargo.lock:313:1
    │
313 │ openssl 0.10.64 registry+https://github.com/rust-lang/crates.io-index
    │ --------------------------------------------------------------------- security vulnerability detected
    │
    = ID: RUSTSEC-2024-0357
    = Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0357
    = Previously, `MemBio::get_buf` called `slice::from_raw_parts` with a null-pointer, which violates the functions invariants, leading to undefined behavior. In debug builds this would produce an assertion failure. This is now fixed.
    = Announcement: sfackler/rust-openssl#2266
    = Solution: Upgrade to >=0.10.66 (try `cargo update -p openssl`)
```
@doitian doitian requested a review from a team as a code owner July 22, 2024 01:30
@doitian doitian requested review from quake and removed request for a team July 22, 2024 01:30
@doitian
Copy link
Member Author

doitian commented Jul 22, 2024

Also chery picked to rc/v0.117.x 5daf192

@zhangsoledad zhangsoledad enabled auto-merge July 22, 2024 02:47
@zhangsoledad zhangsoledad added this pull request to the merge queue Jul 22, 2024
@eval-exec eval-exec mentioned this pull request Jul 22, 2024
Merged
Merged via the queue into nervosnetwork:develop with commit 471b03e Jul 22, 2024
31 of 32 checks passed
@doitian doitian deleted the upgrade-openssl branch October 11, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@eval-exec eval-exec eval-exec approved these changes

@quake quake Awaiting requested review from quake quake is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doitian @zhangsoledad @eval-exec