Fix Unit Test and Integration Test on MacOS and Windows platform #4566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_load_unverified thread exit before process block
eval-exec
requested review from
doitian,
quake,
zhangsoledad,
driftluo and
chenyukang
and removed request for
a team
eval-exec
changed the title
eval-exec
changed the title
doitian
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Want to fix:
https://github.com/nervosnetwork/ckb/actions/runs/10256636258/job/28376143614
https://github.com/nervosnetwork/ckb/actions/runs/10256636255/job/28376145250
In Integration Test, when node crash, print last 500 lines of log.
In Unit test
fn basic_sync, wait init_load_unverified thread exit before process bad blockRelated changes
Check List
Tests
Side effects
Release note