Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add proxy and onion support for ckb-network #4733

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

[WIP] Add proxy and onion support for ckb-network #4733

wants to merge 13 commits into from
+1,490 −139

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Dec 2, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4473

What is changed and how it works?

What's Changed:

Related changes

  • Add ProxyConfig and OnionConfig to network config
  • Support socks5 authentication like: socks5://<username>:<password>@server_host:port
  • Support connect to onion ckb node, and listen on the onion hidden network
  • [WIP] Integration test for ckb-onion
    • node1(onion) can succesfully connect node2(node2) in the onion network
    • noode1(onion) can succesfully connect to node2(non-onion)
    • node1(onion) connect node0(onion), node2(onion) connect to node0, expect node1 and node2 can reach each other
    • node1(non-onion) can use [network.proxy] via a normal socks5 proxy
  • ckb-onion related configuration's documentation in ckb.toml

Note:
Need to setup promethues for tor process: https://gitlab.torproject.org/tpo/onion-services/onionprobe

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec force-pushed the exec/proxy branch 5 times, most recently from fe5d648 to e55f631 Compare December 5, 2024 03:37
@eval-exec
Copy link
Collaborator Author

nervosnetwork/tentacle#392

@eval-exec eval-exec force-pushed the exec/proxy branch 10 times, most recently from de239fd to f9f0733 Compare December 24, 2024 06:15
@eval-exec eval-exec mentioned this pull request Dec 30, 2024
Closed
@eval-exec eval-exec force-pushed the exec/proxy branch 3 times, most recently from 587e905 to 865759d Compare December 31, 2024 08:49
@eval-exec eval-exec force-pushed the exec/proxy branch 3 times, most recently from 260c2fe to c0f57bb Compare January 21, 2025 10:45
@eval-exec eval-exec force-pushed the exec/proxy branch 5 times, most recently from 6169766 to 12e27f6 Compare January 24, 2025 06:29
@eval-exec eval-exec marked this pull request as ready for review January 24, 2025 06:42
@eval-exec eval-exec requested a review from a team as a code owner January 24, 2025 06:42
@eval-exec eval-exec requested review from quake and removed request for a team January 24, 2025 06:42
@eval-exec eval-exec changed the title [WIP] Add proxy support for ckb [WIP] Add proxy and onion support for ckb-network Jan 24, 2025
@eval-exec eval-exec marked this pull request as draft January 24, 2025 06:42
@eval-exec eval-exec marked this pull request as ready for review January 24, 2025 06:46
@eval-exec eval-exec force-pushed the exec/proxy branch 2 times, most recently from b504b02 to e4d46af Compare January 24, 2025 07:08
@eval-exec eval-exec force-pushed the exec/proxy branch 3 times, most recently from 1d013b3 to e7209ef Compare January 24, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake Awaiting requested review from quake quake is a code owner automatically assigned from nervosnetwork/ckb-dev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
m:network
Projects
CKB Kanban
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set proxy for ckb node
1 participant
@eval-exec