Query missing broadcast messages from peers #428
+571
−453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please rebase to resolve the conflicting |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #428 +/- ##
===========================================
- Coverage 50.32% 50.16% -0.17%
===========================================
Files 48 48
Lines 31806 31844 +38
===========================================
- Hits 16006 15974 -32
- Misses 15800 15870 +70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Only used to save our NodeAnnouncement to the graph. We don't really need to have our own NodeAnnouncement in the graph.
contrun
force-pushed
the
retriable-gossip-querying
branch
from
3900f23 to
2c587a0
Compare
contrun
force-pushed
the
retriable-gossip-querying
branch
from
aa34394 to
a1f2473
Compare
quake
requested changes
Jan 27, 2025
| store: S, | ||
| chain_actor: ActorRef<CkbChainMessage>, | ||
| supervisor: ActorCell, | ||
| ) -> Self { |
There was a problem hiding this comment.
suggest to return (Self, GossipProtocolHandle), then we can remove the network_control_sender field and create_protocol_handle fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.