-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): added dropdown for nestjs versions #1638
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll admit, this looks pretty cool. I personally like that it opens a new tab for the version as the version is just a snapshot of the last push for that version.
Definitely a blast from the past to see v4 and v5.
Good addition. I think we should make the label include the version or do something equivalent like laravel: https://laravel.com/docs/8.x We can do : |
9a4a4b6
to
09dcdd4
Compare
<a href="https://docs.nestjs.com/v8/" target="_blank">8.x</a> | ||
<a href="https://docs.nestjs.com/v7/" target="_blank">7.x</a> | ||
<a href="https://docs.nestjs.com/v6/" target="_blank">6.x</a> | ||
<a href="https://docs.nestjs.com/v5/" target="_blank">5.x</a> | ||
<a href="https://docs.nestjs.com/v4/" target="_blank">4.x</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a href="https://docs.nestjs.com/v8/" target="_blank">8.x</a> | |
<a href="https://docs.nestjs.com/v7/" target="_blank">7.x</a> | |
<a href="https://docs.nestjs.com/v6/" target="_blank">6.x</a> | |
<a href="https://docs.nestjs.com/v5/" target="_blank">5.x</a> | |
<a href="https://docs.nestjs.com/v4/" target="_blank">4.x</a> | |
<a href="https://docs.nestjs.com/v8/" target="_self">8.x</a> | |
<a href="https://docs.nestjs.com/v7/" target="_self">7.x</a> | |
<a href="https://docs.nestjs.com/v6/" target="_self">6.x</a> | |
<a href="https://docs.nestjs.com/v5/" target="_self">5.x</a> | |
<a href="https://docs.nestjs.com/v4/" target="_self">4.x</a> |
wouldn't this behavior be better? I mean, if one want to see the docs of another version, they problably don't care about the current one
This would be good for reviewing documentation on migrating older versions. |
d4c188c
to
3013d01
Compare
3be5efa
to
afedda4
Compare
Remove incorrect parentheses
docs: tiny typo
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: "takes its cue from this problem" #64
What is the new behavior?
N/A
Does this PR introduce a breaking change?
Other information
This PR, added to the dropdown for nestjs versions, could be a useful addition to the documentation, to navigate between the old and new versions of NestJS, I am attaching here two screenshots both when the menu is open and when it is closed.
Also in the future as there are more versions of NestJS it could be useful.
dropdown open:
dropdown close:
a small clip:
draft-version-nest-menu.mov