Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor) Replace federation with subgraph #1813

Closed
wants to merge 2 commits into from
Closed

(refactor) Replace federation with subgraph #1813

wants to merge 2 commits into from

Conversation

iMobs
Copy link
Contributor

@iMobs iMobs commented Oct 20, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Replaces @apollo/federation with @apollo/subgraph. The buildFederatedSchema method was deprecated and under the hood, just a reexport of buildSubgraphSchema.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

With this in place, the nest docs on federation should be updated to add @apollo/subgraph instead of @apollo/federation.

I've also added type annotations for the dynamic imports since loadPackage just returns any.

Followup to #1797

Ian Mobley added 2 commits October 20, 2021 08:44
buildFederatedSchema was a deprecated reexport of buildSubgraphSchema.
Also added types of the dynamic imports so that they're not just any.
@kodeine

This comment has been minimized.

@nestjs nestjs locked and limited conversation to collaborators Nov 23, 2021
@kamilmysliwiec
Copy link
Member

This has been address in this PR #1893

@iMobs iMobs deleted the replace-federation-with-subgraph branch January 24, 2022 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants