Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Chun-Hung Tseng <[email protected]>
  • Loading branch information
bruelea and henrybear327 authored Nov 27, 2024
1 parent e1a534a commit a13049e
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions internal/controller/iprange_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -241,12 +241,7 @@ func (r *IpRangeReconciler) logErrorSetConditionAndCreateEvent(ctx context.Conte
r.Recorder.Event(o, eventType, condition.Reason, condition.Message)
}

err := r.Client.Status().Update(ctx, o)
if err != nil {
return err
}

return nil
return r.Client.Status().Update(ctx, o)
}

func (r *IpRangeReconciler) generateNetboxIpRangeModelFromIpRangeSpec(o *netboxv1.IpRange, req ctrl.Request, lastIpRangeMetadata string) (*models.IpRange, error) {
Expand Down

0 comments on commit a13049e

Please sign in to comment.