Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support reservation of IpRanges #130
base: main
Are you sure you want to change the base?
Support reservation of IpRanges #130
Changes from 9 commits
4de8997
146e13a
6e2c983
050b970
3385393
10e2307
a12f7d0
16ae6db
f86fa10
56e8cbd
e1a534a
a13049e
87bdd6c
afc40a6
5c22d56
a06e20d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a current de-facto hard limit here which is at 50 (should be reproducible by trying to create a iprc with .spec.size 51 in an empty /16 prefix) and a soft limit that might be even lower (depending on the fragmentation of IPs/IP Ranges in the prefix). I assume this is due to pagination in the API. I propose to add validation Maximum=50 here and add a comment to this field but leave the code as is for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a validation rule for maximum value for size until pagination is added to the function searching an available iprange.