Merge pull request #146 from netdevops/issue-145-v3

Addresses Issue 145 in in V3

hier_config/platforms/arista_eos/driver.py

@@ -145,9 +145,6 @@ def _instantiate_rules() -> HConfigDriverRules:
                         MatchRule(re_search="neighbor \\S+ description"),
                     ),
                 ),
-                IdempotentCommandsRule(
-                    match_rules=(MatchRule(startswith="snmp-server community"),),
-                ),
                 IdempotentCommandsRule(
                     match_rules=(MatchRule(startswith="snmp-server location"),),
                 ),

hier_config/platforms/cisco_ios/view.py

@@ -274,7 +274,7 @@ def location(self) -> str:
 
     @property
     def stack_members(self) -> Iterable[StackMember]:
-        """stacking
+        """Stacking
         member 1 type "JL123" mac-address abc123-abc123
         member 1 priority 255
         member 2 type "JL123" mac-address abc123-abc123

hier_config/platforms/cisco_nxos/driver.py

@@ -311,9 +311,6 @@ def _instantiate_rules() -> HConfigDriverRules:
                 IdempotentCommandsRule(
                     match_rules=(MatchRule(startswith="mac address-table aging-time"),),
                 ),
-                IdempotentCommandsRule(
-                    match_rules=(MatchRule(startswith="snmp-server community"),),
-                ),
                 IdempotentCommandsRule(
                     match_rules=(MatchRule(startswith="snmp-server location"),)
                 ),

hier_config/platforms/cisco_xr/driver.py

@@ -261,9 +261,6 @@ def _instantiate_rules() -> HConfigDriverRules:
                         MatchRule(startswith="ipv4 address"),
                     ),
                 ),
-                IdempotentCommandsRule(
-                    match_rules=(MatchRule(startswith="snmp-server community"),),
-                ),
                 IdempotentCommandsRule(
                     match_rules=(MatchRule(startswith="snmp-server location"),),
                 ),

hier_config/platforms/hp_procurve/view.py

@@ -292,7 +292,7 @@ def location(self) -> str:
 
     @property
     def stack_members(self) -> Iterable[StackMember]:
-        """stacking
+        """Stacking
         member 1 type "JL123" mac-address abc123-abc123
         member 1 priority 255
         member 2 type "JL123" mac-address abc123-abc123

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "hier-config"
-version = "3.2.1"
+version = "3.2.2"
 description = "A network configuration query and comparison library, used to build remediation configurations."
 packages = [
     { include="hier_config", from="."},
@@ -146,6 +146,7 @@ ignore = [
     # These can be re-enabled once we deprecate Python 3.9
     "FA100",  # future-rewritable-type-annotation
     "UP007",  # non-pep604-annotation
+    "UP045",  # Use `X | None` for type annotations
 ]
 
 [tool.ruff.lint.flake8-pytest-style]

tests/test_utils.py

@@ -57,12 +57,12 @@ def test_load_hier_config_tags_success(tags_file_path: str) -> None:
     assert isinstance(result, tuple), "Result should be a tuple of TagRule objects."
     assert len(result) == 4, "There should be four TagRule objects."
     assert isinstance(result[0], TagRule), "Each element should be a TagRule object."
-    assert result[0].apply_tags == {
-        "safe"
-    }, "First tag should have 'safe' as an applied tag."
-    assert result[3].apply_tags == {
-        "manual"
-    }, "Last tag should have 'manual' as an applied tag."
+    assert result[0].apply_tags == {"safe"}, (
+        "First tag should have 'safe' as an applied tag."
+    )
+    assert result[3].apply_tags == {"manual"}, (
+        "Last tag should have 'manual' as an applied tag."
+    )
 
 
 def test_load_hier_config_tags_file_not_found() -> None: