format code #1
Merged
format code #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 8, 2024 17:47
|
Damn I really appreciate it. I was looking for someone to help me do it . Thanks a lot.... |
Please, I saw that your codes are messed up, I arranged them, and you were using old libraries, so this option is not recommended, at least gr is recommended version 8.2.2 |
aikrq
suggested changes
May 9, 2024
Comment on lines
+44
to
+47
| implementation 'androidx.appcompat:appcompat:1.7.0-alpha03' | ||
| implementation 'com.google.android.material:material:1.12.0-alpha03' | ||
| implementation 'com.google.code.gson:gson:2.10.1' | ||
| implementation 'com.squareup.okhttp3:okhttp:5.0.0-alpha.12' |
| @@ -1,98 +1,99 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| @@ -1,22 +1,22 @@ | |||
| package nethical.digipaws; | |||
There was a problem hiding this comment.
why are you using 2 space tab instead of 4?
you are already using 4 space tab in some files.
aikrq
suggested changes
May 9, 2024
| @@ -0,0 +1,31 @@ | |||
| name: Android CI | |||
There was a problem hiding this comment.
Why are you adding unwanted changes?
Pull request title: Format code
| @@ -6,7 +6,7 @@ plugins { | |||
|
|
|||
| android { | |||
| namespace 'nethical.digipaws' | |||
| compileSdk 33 | |||
| compileSdk 34 | |||
Comment on lines
+31
to
+32
| sourceCompatibility JavaVersion.VERSION_17 | ||
| targetCompatibility JavaVersion.VERSION_17 |
|
💀💀 |
|
I have reset all changes. Please fix and reopen another pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi me formating all xml and java and adding lastversion androidx and material