This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #777
This PR adds
webm
files to the defaultfetchinclude
. This means that users who are making use of LFS and havewebm
video files won't have issues when deploying sites 👍I struggled for about a week trying to find the exact set of levers to pull to make LFS work with my site and I came across this thread that ultimately solved the issue: https://answers.netlify.com/t/webm-not-working-under-git-hub-lfs/14460/4
My reasoning for opening this PR is that I'm assuming (possibly naively) that this can't hurt anyone's existing sites, and it just unblocks people that happen to be using LFS with
webm
files.For us to review and ship your PR efficiently, please perform the following steps:
- [ ] Update or add tests (if any source code was changed or added) 🧪- [ ] Update the included software doc (if you updated included software) 📄- [ ] Update or add documentation (if features were changed or added) 📝So I have made the only check that I have control over pass 🤔 I don't know how to make the label check pass since I'm not able to label this PR 🤔
A picture of a cute animal (not mandatory, but encouraged)
My profile pic has a cute animal in it 😉 his name is Rodney 🐶