Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.8: Fix arg usage for downstream builds #558

Merged

Conversation

OlivierCazade
Copy link
Contributor

Description

Fix arg usage for downstream builds

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@msherif1234
Copy link
Contributor

/lgtm

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.61%. Comparing base (ba3e933) to head (237be96).
Report is 1 commits behind head on release-1.8.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.8     #558   +/-   ##
============================================
  Coverage        27.61%   27.61%           
============================================
  Files               46       46           
  Lines             4940     4940           
============================================
  Hits              1364     1364           
  Misses            3473     3473           
  Partials           103      103           
Flag Coverage Δ
unittests 27.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@msherif1234
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit dbcc8f7 into netobserv:release-1.8 Feb 11, 2025
9 checks passed
@jotak
Copy link
Member

jotak commented Feb 12, 2025

@OlivierCazade can you apply that on main branch as well? I need it to fix fips compliance

OlivierCazade added a commit to OlivierCazade/netobserv-agent that referenced this pull request Feb 12, 2025
jotak pushed a commit that referenced this pull request Feb 12, 2025
* Align downstream dockerfile with the upstream one (#557)

* Align downstream dockerfile with the upstream one

* Update Dockerfile.downstream

Co-authored-by: Julien Pinsonneau <[email protected]>

---------

Co-authored-by: Julien Pinsonneau <[email protected]>

* Fix arg usage for downstream builds (#558)

---------

Co-authored-by: Julien Pinsonneau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants