Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align downstream dockerfile with the upstream one #560

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Align downstream dockerfile with the upstream one #560

merged 2 commits into from
Feb 12, 2025

Conversation

OlivierCazade
Copy link
Contributor

Description

  • Align downstream dockerfile with the upstream one

  • Update Dockerfile.downstream

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

OlivierCazade and others added 2 commits February 12, 2025 11:16
@OlivierCazade @jpinsonneau
Align downstream dockerfile with the upstream one (netobserv#557)
8e3e21d 
* Align downstream dockerfile with the upstream one

* Update Dockerfile.downstream

Co-authored-by: Julien Pinsonneau <[email protected]>

---------

Co-authored-by: Julien Pinsonneau <[email protected]>
@OlivierCazade
Fix arg usage for downstream builds (netobserv#558)
af89676
@OlivierCazade OlivierCazade requested a review from jotak February 12, 2025 10:18
jotak
jotak approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 12, 2025
@OlivierCazade
Copy link
Contributor Author

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OlivierCazade

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak merged commit fc3727d into netobserv:main Feb 12, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotak jotak jotak approved these changes

Assignees

@jotak jotak

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OlivierCazade @jotak