WIP: IPsec support #1085
Draft
WIP: IPsec support #1085
+56
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
==========================================
- Coverage 62.49% 62.41% -0.08%
==========================================
Files 77 77
Lines 11581 11593 +12
==========================================
- Hits 7237 7236 -1
- Misses 3887 3897 +10
- Partials 457 460 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
msherif1234
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
msherif1234
removed
the
ok-to-test
msherif1234
force-pushed
the
ipsec
branch
3 times, most recently
from
1425eb0 to
c970f00
Compare
jpinsonneau
reviewed
Feb 4, 2025
| @@ -166,6 +167,7 @@ const ( | |||
| PacketTranslation AgentFeature = "PacketTranslation" | |||
| EbpfManager AgentFeature = "EbpfManager" | |||
| UDNMapping AgentFeature = "UDNMapping" | |||
| IPSEC AgentFeature = "IPSEC" | |||
There was a problem hiding this comment.
Suggested change
| IPSEC AgentFeature = "IPSEC" | |
| IPSEC AgentFeature = "IPSec" |
There was a problem hiding this comment.
or
Suggested change
| IPSEC AgentFeature = "IPSEC" | |
| IPSEC AgentFeature = "IPsec" |
jpinsonneau
reviewed
Feb 4, 2025
| @@ -1415,6 +1425,9 @@ fields: | |||
| - name: K8S_ClusterName | |||
| type: string | |||
| description: Cluster name or identifier | |||
| - name: EncryptedFlow | |||
| type: boolean | |||
There was a problem hiding this comment.
Do you think we will be able to get more info that that in the future ?
It would be interesting to use another type here if so
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:f7e644e make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-f7e644eOr as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-f7e644e
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
Signed-off-by: Mohamed Mahmoud <[email protected]>
github-actions
bot
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.