Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated server command line options with --listen #198

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ntalentac
Copy link
Contributor

@ntalentac ntalentac commented Feb 9, 2023

fixed now missing cli option. The -p no longer exists.


This change is Reviewable

fixed now missing cli option. The -p no longer exists.
Copy link
Contributor

@FR4NK-W FR4NK-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and noticing that the scion-bwtestserver now only uses the --listen flag.
The -s flag still exists and is used by the scion-bwtestclient.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions / 0 of 1 LGTMs obtained / 0 of 1 approvals obtained


content/apps/bwtester.md line 24 at r1 (raw file):

scion-bwtestclient -p

scion-bwtestclient in the latest version (3.3.1) is still using the -s flag to specify the server address.

Code quote:

-p 

content/apps/bwtester.md line 50 at r1 (raw file):

where -p specifies your server port.

please also update the comment

Suggestion:

where `--listen` specifies the server (optional address and) port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants