Parser for Apple peering notifications #227
Conversation
slyngshede
requested review from
chadell,
glennmatthews,
pke11y,
scetron and
jvanderaa
as code owners
| m = re.search(pattern, text) | ||
| return [CircuitImpact( | ||
| circuit_id=f'AS{m.group(1)}', | ||
| impact=Impact.NO_IMPACT)] |
There was a problem hiding this comment.
I guess you would like to mark the circuit state during the maintenance as OUTAGE? NO_IMPACT is supposed for a circuit that it's not being affected during the maintenance period
|
@slyngshede |
|
Yes, sorry, I got distracted. Apple apparently also have different time formats for different parts of the world, so I need to update the patch anyway. |
|
Hi @slyngshede , there is still some linting problem. anything we can help you with? |
|
@chadell No, I got it working, just been busy with other project :-) |
|
@slyngshede , if you can't finish it, I could do it for you. |
|
@slyngshede , would you like to complete this? or do you mind if I bring it to the finish line? |
|
@chadell not at all, please go ahead. I have plenty of other parsers to look at when I find the time again :-) |
|
done in #303 |
Parser for Apple peering notification emails. We haven't yet seen anything that can be classified as other than "CONFIRMED"
The EmailSubjectParser behaves slightly different than one would expect based on the naming, in that it just get the entire email text, without line break. I would expect that it would receive ONLY the subject line, but that doesn't seem to be the case. Am I using it wrong perhaps?