Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ordering after data normalization. #112

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Add ordering after data normalization. #112

merged 2 commits into from
Jan 24, 2024

Conversation

pszulczewski
Copy link
Collaborator

Some device commands elements may come in different order between pre and post check, especially when a device is rebooted after SW upgrade. This behavior was observed for show lldp neighbors when the order is different after reload what leads to failed post-check.

This PR adds key sorting when data normalization is used with key anchoring.

Tests have been extended to cover that LLDP case with different order of neighbors between pre and post checks.
Updates in test_operators.py just change the order of elements in expected results.

lvrfrc87
lvrfrc87 previously approved these changes Jan 22, 2024
Copy link
Collaborator

@lvrfrc87 lvrfrc87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for raising this!

@pszulczewski pszulczewski merged commit 821760d into develop Jan 24, 2024
14 checks passed
@pszulczewski pszulczewski deleted the add_sorting branch January 24, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants