RAG with Retrieval of Top Documents and Answer Generation #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihir86
changed the title
neubig
requested changes
Apr 2, 2024
neubig
approved these changes
Apr 16, 2024
Comment on lines
+19
to
+21
| base (LanguageModel): The base language model to be modified. | ||
| datastore (Datastore): The datastore object for document index. | ||
| max_results (int, optional): Maximum number of results to retrieve. Defaults to 1. |
There was a problem hiding this comment.
Suggested change
| base (LanguageModel): The base language model to be modified. | |
| datastore (Datastore): The datastore object for document index. | |
| max_results (int, optional): Maximum number of results to retrieve. Defaults to 1. | |
| base: The base language model to be modified. | |
| datastore: The datastore object for document index. | |
| max_results: Maximum number of results to retrieve. |
Let's not put types in the comments, since they're already in the function signature and duplicating them could move the two out of sync.
| """Read JSONL file and convert it into a dictionary with document ID as keys and contents as values. | ||
|
|
||
| Args: | ||
| file_path (str): Path to the JSONL file. |
There was a problem hiding this comment.
Suggested change
| file_path (str): Path to the JSONL file. | |
| file_path: Path to the JSONL file. |
| context = ' '.join([self.doc_dict[str(key.docid)] for key in top_docs]) | ||
| prompt = None | ||
| if condition is not None: | ||
| prompt = "Please answer the following question, given its context.\nQuestion: " + condition + "\nContext: " + context + "\nAnswer: " |
There was a problem hiding this comment.
We don't need to fix it in this PR, but could you open an issue to make the prompt for RAGLanguageModel configurable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request provides an implementation to RAGLanguageModel which retrieves the top documents for every query and passes it to the LM for generating an answer to the query, given the top document as context
References