Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Evaluation for RAG #50

Merged
merged 45 commits into from
Apr 21, 2024
Merged

Added Evaluation for RAG #50

merged 45 commits into from
Apr 21, 2024

Conversation

mihir86
Copy link
Collaborator

@mihir86 mihir86 commented Apr 19, 2024

Description

This PR adds a new class for evaluating the performance of RAG on QnA types of datasets. I have also fixed a small bug in the retrieval where I only consider the 'text' column for encoding. I have made it more flexible for the user.

References

@mihir86 mihir86 requested a review from neubig April 19, 2024 01:37
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I have some suggestions.

examples/rag/NQ_example.ipynb Outdated Show resolved Hide resolved
llments/datastore/datastore.py Outdated Show resolved Hide resolved
llments/eval/eval.py Outdated Show resolved Hide resolved
llments/eval/rag.py Outdated Show resolved Hide resolved
llments/eval/rag.py Outdated Show resolved Hide resolved
llments/eval/rag.py Show resolved Hide resolved
llments/eval/rag.py Outdated Show resolved Hide resolved
@mihir86 mihir86 requested a review from neubig April 20, 2024 22:46
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mihir86 ! You've done a lot of work on this PR, and I really appreciate it.

I think that we can generalize the typing a bit more, but let me take a stab at that in a follow-up PR.

#51

@neubig neubig merged commit a9a4979 into main Apr 21, 2024
5 checks passed
@neubig neubig deleted the mihirban/retriever branch April 21, 2024 11:45
@mihir86
Copy link
Collaborator Author

mihir86 commented Apr 21, 2024

Thank you! Yes, surely, do let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants