Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CommunityLM with RAG #74

Merged
merged 57 commits into from
Dec 9, 2024
Merged

Added CommunityLM with RAG #74

merged 57 commits into from
Dec 9, 2024

Conversation

mihir86
Copy link
Collaborator

@mihir86 mihir86 commented Sep 28, 2024 •
edited
Loading

Description

This PR adds another example of using RAG, where we use RAG for generating responses instead of finetuning the LLM.

References

mihir86 added 30 commits March 28, 2024 02:12
@mihir86
Initial changes
6e01dba
@mihir86
Merge branch 'main' of https://github.com/neulab/llments into mihirba…
7a2ac0d 
…n/retriever
@mihir86
Completing RAG pipeline v1
ef51974
@mihir86
Merge branch 'main' of https://github.com/neulab/llments into mihirba…
5b9bf96 
…n/retriever
@mihir86
fixes
b6bdaea
@mihir86
fixes
378549a
@mihir86
fixes
41043fc
@mihir86
fixes
61d5cd4
@mihir86
fixes
feb486f
@mihir86
fixes
164091b
@mihir86
fixes
a6f1f8c
@mihir86
fixes
4fa7ce4
@mihir86
fixes
5f2ec31
@mihir86
fixes
b998804
@mihir86
fixes
83178f4
@mihir86
Merge branch 'main' of https://github.com/neulab/llments into mihirba…
d604bcd 
…n/retriever
@mihir86
fixing comments
e463293
@mihir86
fixing comments
b1b6582
@mihir86
Initial commit
401bdcf
@mihir86
Merge branch 'main' of https://github.com/neulab/llments into mihirba…
7ae994e 
…n/retriever
@mihir86
removed token in huggingface lm
23ab385
@mihir86
fixing comments
4ce8d25
@mihir86
fix ruff
d8269a1
@mihir86
fixes
54b9104
@mihir86
fixes
830fa80
@mihir86
fixes
e546ea9
@mihir86
fixes
0922190
@mihir86
fixes
189b286
@mihir86
fix
f4ce6e6
@mihir86
fix
412f419
@mihir86 mihir86 requested a review from neubig September 28, 2024 00:34
@mihir86 mihir86 self-assigned this Sep 28, 2024
@mihir86 mihir86 changed the title Mihirban/communitylm Added CommunityLM with RAG Sep 28, 2024
neubig
neubig reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, but why is it marked as "draft"?

@mihir86 mihir86 marked this pull request as ready for review October 10, 2024 21:13
@mihir86
Copy link
Collaborator Author

mihir86 commented Oct 10, 2024

I modified the code to run the RAGLM for CommunityLM. Marked it as ready to review now.

@neubig neubig self-requested a review December 5, 2024 17:55
neubig
neubig reviewed Dec 7, 2024
View reviewed changes
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mihir86 , could you please try to fix the linting issues and request my review when done? Thanks!

@mihir86
Copy link
Collaborator Author

mihir86 commented Dec 8, 2024

I pushed code with the new env. That worked.

@mihir86 mihir86 requested a review from neubig December 8, 2024 00:31
@mihir86 mihir86 linked an issue Dec 8, 2024 that may be closed by this pull request
Implement RAG for CommunityLM #75
Closed
neubig
neubig reviewed Dec 9, 2024
View reviewed changes
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments!

examples/community_lm/community_lm.ipynb Outdated Show resolved Hide resolved
examples/community_lm/community_lm_rag.ipynb Show resolved Hide resolved
@mihir86 mihir86 requested a review from neubig December 9, 2024 03:40
@neubig neubig merged commit 96e689c into main Dec 9, 2024
5 checks passed
@neubig neubig deleted the mihirban/communitylm branch December 9, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neubig neubig neubig approved these changes

Assignees

@mihir86 mihir86

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement RAG for CommunityLM
2 participants
@mihir86 @neubig