Dev #46
Merged
Dev #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 78.42% 78.54% +0.12%
==========================================
Files 17 17
Lines 1233 1240 +7
Branches 268 269 +1
==========================================
+ Hits 967 974 +7
Misses 253 253
Partials 13 13 ☔ View full report in Codecov by Sentry. |
maxme1
reviewed
Apr 2, 2024
imops/crop.py
Outdated
Comment on lines
38
to
40
| shape = np.asarray(shape) | ||
| if not np.issubdtype(shape.dtype, np.integer): | ||
| raise ValueError(f'`shape` must be of integer dtype, got {shape.dtype}') |
There was a problem hiding this comment.
mb move this to a function? we're using this logic in several places anyway
imops/interp1d.py
Outdated
| @@ -137,7 +137,9 @@ def __init__( | |||
| njit_kwargs = {kwarg: getattr(backend, kwarg) for kwarg in backend.__dataclass_fields__.keys()} | |||
| self.src_interp1d = njit(**njit_kwargs)(numba_interp1d) | |||
|
|
|||
| def __call__(self, x_new: np.ndarray) -> np.ndarray: | |||
| def __call__(self, x_new: np.ndarray, use_torch: bool = False) -> np.ndarray: | |||
There was a problem hiding this comment.
use_torch is too hacky. m.b. this should be specified through the backend?
maxme1
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.