C++ #49
Merged
C++ #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 77.52% 78.42% +0.90%
==========================================
Files 17 17
Lines 1228 1233 +5
Branches 265 268 +3
==========================================
+ Hits 952 967 +15
+ Misses 258 253 -5
+ Partials 18 13 -5 ☔ View full report in Codecov by Sentry. |
maxme1
reviewed
Feb 1, 2024
imops/interp2d.py
Outdated
| @@ -81,7 +81,7 @@ def __call__(self, points: np.ndarray, values: np.ndarray = None, fill_value: fl | |||
| points: np.ndarray | |||
| 2-D array of data point coordinates to interpolate at | |||
| values: np.ndarray | |||
| 1-D array of fp32/fp64 values to use at initial points. If passed, existing values will be rewritten | |||
| 1-D array of fp32/fp64 values to use at initial points. If passed, existing values will NOT be rewritten | |||
There was a problem hiding this comment.
"If passed, existing values will NOT be rewritten" - you don't need to specify this. This is what the user expects anyway
maxme1
reviewed
Feb 1, 2024
imops/interp2d.py
Outdated
| @@ -90,16 +90,16 @@ def __call__(self, points: np.ndarray, values: np.ndarray = None, fill_value: fl | |||
| new_values: np.ndarray | |||
| interpolated values at given points | |||
| """ | |||
| self.values = values or self.values | |||
| x_values = values if values is not None else self.values | |||
There was a problem hiding this comment.
why not just
if values is None:
values = self.values? the new variable seems redundant
maxme1
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed microbug in interp2d