Dev #59
Merged
Dev #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 78.78% 79.20% +0.42%
==========================================
Files 17 18 +1
Lines 1282 1308 +26
Branches 280 281 +1
==========================================
+ Hits 1010 1036 +26
Misses 256 256
Partials 16 16 ☔ View full report in Codecov by Sentry. |
maxme1
reviewed
Aug 2, 2024
imops/radon.py
Outdated
Comment on lines
15
to
18
| try: | ||
| from numpy.lib.array_utils import normalize_axis_tuple | ||
| except ModuleNotFoundError: | ||
| from numpy.core.numeric import normalize_axis_tuple |
There was a problem hiding this comment.
create a compat.py file and move all such failsafe imports there. then just import from it
maxme1
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.