Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static type checker errors #8

Closed
wants to merge 4 commits into from
Closed

Conversation

senthurayyappan
Copy link
Member

@senthurayyappan senthurayyappan commented Nov 4, 2024

Fixes #7

Fix static type checker errors and add type annotations across multiple files.

  • onshape_api/connect.py

    • Add type annotations to all functions and methods.
    • Fix type errors in Client class methods.
    • Ensure all imports are correctly typed.
  • onshape_api/data/preprocess.py

    • Add type annotations to all functions.
    • Fix type errors in extract_ids and get_assembly_df functions.
  • onshape_api/graph.py

    • Add type annotations to all functions.
    • Fix type inconsistencies in create_graph and get_robot_link functions.
  • onshape_api/log.py

    • Add type annotations to all methods.
    • Fix type inconsistencies in Logger class methods.
  • onshape_api/models/assembly.py

    • Add type annotations to all classes and methods.
    • Fix type issues in PartInstance and AssemblyInstance classes.
  • onshape_api/models/document.py

    • Add type annotations to all classes and methods.
    • Fix type issues in Document and DocumentMetaData classes.
  • onshape_api/models/element.py

    • Add type annotations to all classes and methods.
    • Fix type issues in Element class.

For more details, open the Copilot Workspace session.

Fixes #7

Fix static type checker errors and add type annotations across multiple files.

* **onshape_api/connect.py**
  - Add type annotations to all functions and methods.
  - Fix type errors in `Client` class methods.
  - Ensure all imports are correctly typed.

* **onshape_api/data/preprocess.py**
  - Add type annotations to all functions.
  - Fix type errors in `extract_ids` and `get_assembly_df` functions.

* **onshape_api/graph.py**
  - Add type annotations to all functions.
  - Fix type inconsistencies in `create_graph` and `get_robot_link` functions.

* **onshape_api/log.py**
  - Add type annotations to all methods.
  - Fix type inconsistencies in `Logger` class methods.

* **onshape_api/models/assembly.py**
  - Add type annotations to all classes and methods.
  - Fix type issues in `PartInstance` and `AssemblyInstance` classes.

* **onshape_api/models/document.py**
  - Add type annotations to all classes and methods.
  - Fix type issues in `Document` and `DocumentMetaData` classes.

* **onshape_api/models/element.py**
  - Add type annotations to all classes and methods.
  - Fix type issues in `Element` class.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/imsenthur/onshape-api/issues/7?shareId=XXXX-XXXX-XXXX-XXXX).
@senthurayyappan senthurayyappan deleted the fix-type-errors branch December 19, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static type checker (Mypy) errors need to be fixed before it gets out of hand
1 participant