Merge pull request #116 from neuroglia-io/fix-resource-oriented-admis…

…sion-problems

Fix the ResourceAdmissionControl to properly document errors that have occured during admission of evaluated resources

src/Neuroglia.Data.Infrastructure.ResourceOriented.Abstractions/Properties/ProblemDescriptions.resx

@@ -133,7 +133,7 @@
     <value>Namespaced resource must reference a valid namespace</value>
   </data>
   <data name="ResourceAdmissionFailed" xml:space="preserve">
-    <value>Failed to admit operation '{operation}' the specified resource '{resource}':\n{errors}</value>
+    <value>Failed to admit operation '{operation}' on the specified resource '{resource}':\r\n{errors}</value>
   </data>
   <data name="ResourceAlreadyExists" xml:space="preserve">
     <value>The specified resource '{resource}' already exists</value>

src/Neuroglia.Data.Infrastructure.ResourceOriented/Services/AdmissionControl.cs

@@ -125,7 +125,7 @@ protected virtual async Task<AdmissionReviewResponse> ValidateAsync(AdmissionRev
 
         var results = tasks.Select(t => t.Result);
         if (results.All(t => t.Allowed)) return new(request.Uid, true);
-        else return new(request.Uid, false, null, new ProblemDetails(ProblemTypes.AdmissionFailed, ProblemTitles.AdmissionFailed, (int)HttpStatusCode.BadRequest, errors: results.Where(r => !r.Allowed && r.Problem != null && r.Problem.Errors != null).SelectMany(r => r.Problem!.Errors!).ToDictionary(e => e.Key, e => e.Value)));
+        else return new(request.Uid, false, null, new ProblemDetails(ProblemTypes.AdmissionFailed, ProblemTitles.AdmissionFailed, (int)HttpStatusCode.BadRequest, errors: results.Where(r => !r.Allowed && r.Problem != null).Select(r => r.Problem!).ToDictionary(p => $"[{p.Status} - {p.Title ?? p.Type?.OriginalString ?? "Unknown"}]", p => new string[] { p.Detail! })));
     }
 
 }