Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Neuroglia.Blazor.Dagre compability issue with NET9 #119

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

JBBianchi
Copy link
Member

Chainable APIs would throw a cast exception (System.InvalidCastException: Specified cast is not valid.) when casting to the IJSObjectReference interface.

This PR fixes this issue by invoking the JS function but returning the .NET object instance (instead of rebuilding it based on the return of the JS function).

@JBBianchi JBBianchi added the bug Something isn't working label Nov 18, 2024
@JBBianchi JBBianchi requested a review from cdavernas November 18, 2024 11:09
@JBBianchi JBBianchi self-assigned this Nov 18, 2024
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cdavernas cdavernas merged commit 8f29d57 into main Nov 18, 2024
1 check passed
@cdavernas cdavernas deleted the fix-dagre-net9 branch November 18, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants