[WIP] BrainAlive Device Integration #171
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Sarthak301
This replaces your #123
INCLUDE_DEVICE_BRAINALIVE
is disabled by default.Uncomment here to enable:
studio/src/Engine/Config.h
Line 48 in 04e1ff5
TODO
Engine must not use Qt or code from Studio.
Specifically in
Engine/Devices/BrainAlive/BrainAliveNodes.cpp
.This must be refactored at minimum before we can merge:
studio/src/Engine/Devices/BrainAlive/BrainAliveNodes.cpp
Line 33 in 04e1ff5
studio/src/Engine/Devices/BrainAlive/BrainAliveNodes.cpp
Line 168 in 04e1ff5